RamiNoodle733 opened a new pull request, #37752:
URL: https://github.com/apache/superset/pull/37752
## Problem
Users were unable to type commas in the D3 format input field for Table
charts. This prevented them from using format strings like ",.2f" (which adds
thousands separators).
## Root Cause
The Select component used for D3 format input has default TOKEN_SEPARATORS
that include comma (','). When users type a comma, it's interpreted as a token
separator rather than part of the input value.
## Solution
1. Added \tokenSeparators\ option to the ControlFormItemSpec type definition
2. Set tokenSeparators to an empty array for both d3NumberFormat and
d3SmallNumberFormat controls
This allows users to type commas in D3 format strings while maintaining the
creatable Select functionality.
## Testing
- Verified that commas can now be typed in D3 format input
- Verified that existing format options still work correctly
- Verified that new custom formats with commas can be created
Fixes #37038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
