Copilot commented on code in PR #37739:
URL: https://github.com/apache/superset/pull/37739#discussion_r2775479981
##########
superset/utils/pandas_postprocessing/histogram.py:
##########
@@ -49,7 +49,7 @@ def histogram(
groupby = []
# drop empty values from the target column
- df = df.dropna(subset=[column])
+ df = df.dropna(subset=[column]).copy()
Review Comment:
PR description mentions a second fix (allow typing comma in D3 format for
Table chart via `tokenSeparators`), but this PR diff only includes a pandas
change in `histogram.py`. If the frontend fix is intended, the related
`ControlFormItemSpec`/table control changes appear to be missing from this PR;
either add them or update the PR title/description to match the actual scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
