Copilot commented on code in PR #37787:
URL: https://github.com/apache/superset/pull/37787#discussion_r2778694470
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx:
##########
@@ -45,7 +45,7 @@ jest.mock('../components/Echart', () => {
const MockEchart = forwardRef<EchartsHandler | null, EchartsProps>(
(props, ref) => {
mockEchart(props);
- void ref;
+ console.log(ref);
return null;
Review Comment:
Avoid using `console.log` in tests to mark variables as used; it adds noisy
output to CI runs and can make debugging harder. Prefer `void ref;` / prefix
with `_ref`, or an explicit eslint/oxlint disable for the unused parameter
instead.
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx:
##########
@@ -228,7 +228,7 @@ test('observes extra control height changes when
ResizeObserver is available', a
};
unobserve(_target: Element): void {
- void _target;
+ console.log(_target);
}
Review Comment:
Avoid `console.log` in test-only helper implementations (e.g., mocked
`ResizeObserver.unobserve`). If this was added to satisfy an unused-parameter
lint rule, prefer `void _target;` or rename the parameter to
`_target`/`__target` (depending on the linter rule) without logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
