bito-code-review[bot] commented on code in PR #37800:
URL: https://github.com/apache/superset/pull/37800#discussion_r2781034299
##########
superset-frontend/src/explore/components/DatasourcePanel/DatasourceItems.tsx:
##########
@@ -105,6 +105,14 @@ export const DatasourceItems = ({
),
);
+ useEffect(() => {
+ setCollapsedFolderIds(
+ new Set(
+ folders.filter(folder => folder.isCollapsed).map(folder => folder.id),
+ ),
+ );
+ }, [folders]);
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>State Reset Bug</b></div>
<div id="fix">
The added useEffect resets the collapsedFolderIds state whenever folders
changes (e.g., during search), since folders.isCollapsed is always false, this
uncollapses all folders unexpectedly, losing user toggles. Remove it to
preserve local state.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
````
</div>
</details>
</div>
<small><i>Code Review Run #3f6a80</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
