sadpandajoe opened a new pull request, #37813: URL: https://github.com/apache/superset/pull/37813
### SUMMARY Migrate Chart List tests from Cypress to RTL, following the test pyramid strategy (unit > integration > E2E). **Changes:** - **Add** RTL test for dashboard crosslinks rendering (verifies links and hrefs for single and multi-dashboard charts) - **Consolidate** 8 individual filter-rendering tests into 1 parameterized test (Search, Type, Dataset, Owner, Certified, Favorite, Dashboard, Modified by) - **Remove** 6 redundant RTL tests across 3 files (duplicate loading states, already-covered dataset column tests, duplicate bulk-select exit paths) - **Delete** Cypress `_skip.filter.test.ts` entirely (5 skipped tests with no assertions) - **Delete** Cypress crosslinks + card-mode sort/filter tests from `list.test.ts` (covered by RTL and `hooks.test.tsx` unit tests) - **Fix** test flakiness: add missing `await` on `userEvent.click`, replace fragile `.ant-alert-close-icon` selector with role-based query, remove no-op `waitFor` **Net result:** -448 / +68 lines across 5 files. All 46 RTL tests pass. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — test-only changes, no UI modifications. ### TESTING INSTRUCTIONS ```bash # Verify all RTL tests pass cd superset-frontend npm run test -- src/pages/ChartList/ChartList.listview.test.tsx npm run test -- src/pages/ChartList/ChartList.cardview.test.tsx npm run test -- src/pages/ChartList/ChartList.test.tsx # Verify unit tests still pass npm run test -- src/views/CRUD/hooks.test.tsx # Verify Cypress file deleted ls superset-frontend/cypress-base/cypress/e2e/chart_list/ # Should only contain list.test.ts (with common actions block retained for future Playwright migration) ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
