richardfogaca commented on PR #37537: URL: https://github.com/apache/superset/pull/37537#issuecomment-3874703221
Thanks for the review! You're right — the flag was hiding the logout button globally, not just in embedded contexts. I've updated the logic to combine it with the existing `isEmbedded()` utility, so it now only hides logout when Superset is actually inside an iframe AND the flag is enabled: ```ts const showLogout = !isEmbedded() || !isFeatureEnabled(FeatureFlag.DisableEmbeddedSupersetLogout); ``` Tests updated to cover all four combinations, and docs clarified accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
