dosubot[bot] commented on issue #37608: URL: https://github.com/apache/superset/issues/37608#issuecomment-3880351227
<!-- Answer --> Yes, that's accurate. The issue with Oracle DATE columns is systemic when used with time grains in Superset—especially for charts like Box Plot that expect TIMESTAMP-typed values. Superset's engine spec for Oracle previously returned DATE types after truncation, but the frontend expects TIMESTAMP for correct temporal grouping. This mismatch can cause invalid dates like 8959-12-31 to appear. A recent PR addressed this by updating the Oracle db engine spec to cast truncated DATE columns to TIMESTAMP, ensuring consistent and correct behavior across affected chart types. This approach aligns Oracle outputs with Superset's expectations and is a safe, targeted fix, as seen in other engine specs too. Testing across chart types is still recommended, but this systemic fix is both plausible and effective for the problem described [source](https://github.com/apache/superset/pull/37702). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/6af54ebe-ac3c-461d-93e6-1fbfab2b0580?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github) [](https://cursor.com/link/prompt?text=Yes%2C%20that%27s%20accurate.%20The%20issue%20with%20Oracle%20DATE%20columns%20is%20systemic%20when%20used%20with%20time%20grains%20in%20Superset%E2%80%94especially%20for%20charts%20like%20Box%20Plot%20that%20expect%20TIMESTAMP-typed%20values.%20Superset%27s%20engine%20spec%20for%20Oracle%20previously%20returned%20DATE%20types%20after%20truncation%2C%20but%20the%20frontend%20expects%20TIMESTAMP%20for%20correct%20temporal%20grouping.%20This%20mismatch%20can%20cause%20invalid%20dates%20like%208959-12-31%20to%20appear.%0A%0AA%20recent%20PR%20addressed%20this%20by%20updating%20the%20Oracle%20db%20engine%20spec%20to%20cast%20truncated%20DATE%20columns%20to%20TIMESTAMP%2C%20ensuring%20consistent%20and%20correct%20behavior%20across%20affected%20chart%20ty pes.%20This%20approach%20aligns%20Oracle%20outputs%20with%20Superset%27s%20expectations%20and%20is%20a%20safe%2C%20targeted%20fix%2C%20as%20seen%20in%20other%20engine%20specs%20too.%20Testing%20across%20chart%20types%20is%20still%20recommended%2C%20but%20this%20systemic%20fix%20is%20both%20plausible%20and%20effective%20for%20the%20problem%20described%20%5Bsource%5D%28https%3A//github.com/apache/superset/pull/37702%29.) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/37608) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
