dosubot[bot] commented on issue #37584: URL: https://github.com/apache/superset/issues/37584#issuecomment-3880372574
<!-- Answer --> No, there isn't a PR open with @saulojb’s changes as of now. About the fix: PR #37018 is the main solution for the infinite refresh loop in nested tabs—it uses a handledRefreshRef and an isLazyLoad flag to prevent duplicate refreshes when tabs become visible after a dashboard refresh, and regression tests confirm it works as intended [source](https://github.com/apache/superset/pull/37018). Your staggered forced refresh approach (spreading chart refreshes over time) isn’t part of the current codebase, but it could help prevent server overload and timeouts when refreshing many charts at once. That’s a useful enhancement, especially for large dashboards, but it’s not strictly necessary for fixing the infinite loop itself. Removing lastRefreshTime from the Tab.jsx effect dependencies is risky unless you’re sure it won’t break legitimate refresh scenarios. The merged fix avoids this by tracking handled refreshes with a ref, so it’s safer and more robust. If you want to propose staggered forced refreshes as an enhancement, it’s worth opening a PR and discussing it with the team. For the infinite loop bug, the merged solution is the right fix. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/5d91b582-4ba9-43c5-aae3-84b902639ef9?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github) [](https://cursor.com/link/prompt?text=No%2C%20there%20isn%27t%20a%20PR%20open%20with%20%40saulojb%E2%80%99s%20changes%20as%20of%20now.%0A%0AAbout%20the%20fix%3A%20PR%20%2337018%20is%20the%20main%20solution%20for%20the%20infinite%20refresh%20loop%20in%20nested%20tabs%E2%80%94it%20uses%20a%20handledRefreshRef%20and%20an%20isLazyLoad%20flag%20to%20prevent%20duplicate%20refreshes%20when%20tabs%20become%20visible%20after%20a%20dashboard%20refresh%2C%20and%20regression%20tests%20confirm%20it%20works%20as%20intended%20%5Bsource%5D%28https%3A//github.com/apache/superset/pull/37018%29.%0A%0AYour%20staggered%20forced%20refresh%20approach%20%28spreading%20chart%20refreshes%20over%20time%29%20isn%E2%80%99t%20part%20of%20the%20current%20codebase%2C%20but%20it%20could%20help%20prevent%20server%20ove rload%20and%20timeouts%20when%20refreshing%20many%20charts%20at%20once.%20That%E2%80%99s%20a%20useful%20enhancement%2C%20especially%20for%20large%20dashboards%2C%20but%20it%E2%80%99s%20not%20strictly%20necessary%20for%20fixing%20the%20infinite%20loop%20itself.%0A%0ARemoving%20lastRefreshTime%20from%20the%20Tab.jsx%20effect%20dependencies%20is%20risky%20unless%20you%E2%80%99re%20sure%20it%20won%E2%80%99t%20break%20legitimate%20refresh%20scenarios.%20The%20merged%20fix%20avoids%20this%20by%20tracking%20handled%20refreshes%20with%20a%20ref%2C%20so%20it%E2%80%99s%20safer%20and%20more%20robust.%0A%0AIf%20you%20want%20to%20propose%20staggered%20forced%20refreshes%20as%20an%20enhancement%2C%20it%E2%80%99s%20worth%20opening%20a%20PR%20and%20discussing%20it%20with%20the%20team.%20For%20the%20infinite%20loop%20bug%2C%20the%20merged%20solution%20is%20the%20right%20fix.) [](https://go.dosu.dev/disc ord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/37584) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
