michaelmorera92 commented on PR #37366: URL: https://github.com/apache/superset/pull/37366#issuecomment-3881575298
I tested the application. # Scenarios tested: ## SQL Lab Editor 1. Navigate to SQL → SQL Lab 2. Open or create a new query tab 3. Type any SQL in the editor (e.g., SELECT * FROM) 4. Verify: Editor text uses IBM Plex Mono (monospace font) ### Evidence <img width="1914" height="999" alt="IBM Plex Mono - SQL editor Row Count" src="https://github.com/user-attachments/assets/f1edf7da-6b9d-4c33-bb6f-62b4a45da051"; /> ## SQL Lab Timer & Row Count 1. In SQL Lab, run a query 2. Verify: The green timer label (e.g., "00:00:00.117") uses monospace font 3. Verify: The row count label in results (e.g., "146 rows") uses monospace font ### Evidence <img width="1914" height="999" alt="IBM Plex Mono - Chart duration and row count" src="https://github.com/user-attachments/assets/c21243bb-0d67-422c-8dd1-c71798bd15d6"; /> ## Chart Builder Metric Popovers 1. Navigate to Charts → click any chart → Edit 2. Click on a metric field to open the metric popover 3. Switch to "Custom SQL" tab 4. Verify: SQL editor in the popover uses IBM Plex Mono ### Evidence <img width="1914" height="999" alt="IBM Plex Mono - Custom SQL" src="https://github.com/user-attachments/assets/34a36eda-9a7f-4a31-a44b-f51b4ee8b427"; /> ## Dataset Editor SQL Expression 1. Navigate to Datasets → click any dataset → Edit 2. Go to Calculated columns tab 3. Expand any calculated column row (click the + icon) 4. Verify: SQL expression editor uses IBM Plex Mono ### Evidence <img width="1914" height="999" alt="IBM Plex Mono - SQL Expression" src="https://github.com/user-attachments/assets/739dfa8d-e1ab-482a-a0ed-e0df8112c37d"; /> ## Query History Duration 1. Navigate to SQL → Query History 2. Verify: Duration labels (green tags like "00:00:00.316") use monospace font ### Evidence <img width="1914" height="999" alt="IBM Plex Mono - Query History SQL" src="https://github.com/user-attachments/assets/6e332b87-ff18-4494-b2f2-891728e08628"; /> Also I create a video comparing the usage of the font family "IBM Plex Mono, monospace" vs not using it. https://github.com/user-attachments/assets/025bbea1-8107-4c15-830b-299401d83895 Also, I completed an exploratory-regression around all timers and sql editors, all the ones that I found uses monospace. NOTE: I made the question to @jeanmassucatto about what I thought could be a possible bug (error message displayed at chart > data > filter > custom SQL), he mentioned we are not doing changes related to "resizes". Error message: ~~`Unexpected error TypeError: Cannot read properties of undefined (reading 'resize') See more`.~~ Conclusion: the application is working as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
