codeant-ai-for-open-source[bot] commented on PR #37884:
URL: https://github.com/apache/superset/pull/37884#issuecomment-3882941771
## **Sequence Diagram**
This PR tightens ESLint/oxlint rules and applies minimal code fixes (remove
redundant length checks, fix nullish/coercion order, remove unsafe optional
chaining, and update tests) so linting passes. The diagram shows the main
developer → linter → code → tests flow.
```mermaid
sequenceDiagram
participant Dev as Developer
participant Config as Lint Config (oxlint/.eslintrc)
participant Repo as Codebase
participant Linter as Lint Runner (npx oxlint / npm run lint)
participant Tests as Test Runner
Dev->>Config: Upgrade rules to errors (no-unsafe-optional-chaining,
no-constant-binary-expression, unicorn/no-useless-length-check, add
react-you-might-not-need-an-effect, storybook rule)
Dev->>Repo: Apply focused fixes (remove .length checks, move ?? inside
Number(), remove ?., adjust tests)
Dev->>Linter: Run linter
Linter->>Repo: Analyze code against updated rules
Repo-->>Linter: No lint errors (fixes applied)
Dev->>Tests: Run tests
Tests-->>Dev: Tests pass
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
