kgabryje opened a new pull request, #37899: URL: https://github.com/apache/superset/pull/37899
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Continuation of http://github.com/apache/superset/pull/37895 `Slice.datasource` executed a raw `db.session.query()` every time it was accessed, causing N+1 query issues across many code paths (dashboard loading, chart lists, etc.). The `Slice.table` relationship already points to the same SqlaTable and is eagerly loaded via `lazy="subquery"` — so the data is already in memory. This PR: - Changes `Slice.datasource` to return `self.table` instead of issuing a DB query - Removes the now-dead `get_datasource` method and `cls_model` property from Slice - Inlines the `DatasourceDAO.sources` lookup into `set_related_perm` (the only remaining caller of cls_model) - Simplifies `Dashboard.datasources` and `Dashboard.datasets_trimmed_for_slices` to use the eagerly-loaded relationship instead of manual batch queries via cls_model Safety: The table relationship filters on datasource_type == 'table'. All chart records use this type — Druid (the only other historical chart datasource) has been removed. All callers already handle None. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1. Load a dashboard with many charts and verify all charts render correctly 2. Check the SQL Lab chart explore view works as expected 3. Verify the chart list API returns correct datasource information ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
