alexandrusoare commented on code in PR #37501:
URL: https://github.com/apache/superset/pull/37501#discussion_r2797867469
##########
superset-frontend/src/explore/components/ExploreChartPanel/index.tsx:
##########
@@ -244,19 +264,22 @@ const ExploreChartPanel = ({
setShowSplit(isOpen);
}, []);
- const renderChart = useCallback(
+ const renderChart = useMemo(
() => (
<div
css={css`
- min-height: 0;
- flex: 1;
- overflow: auto;
+ min-height: 260px;
+ min-width: 300px;
Review Comment:
I am curious on how did we decide on these values? Is there a recurring
pattern for these values?
##########
superset-frontend/src/explore/components/ExploreChartPanel/index.tsx:
##########
@@ -282,7 +305,7 @@ const ExploreChartPanel = ({
})}
{...(chart.chartStatus && { chartStatus: chart.chartStatus })}
/>
- )}
+ ) : null}
</div>
Review Comment:
Why did we drop `&&` for `?` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
