YousufFFFF commented on PR #37712: URL: https://github.com/apache/superset/pull/37712#issuecomment-3899437761
Hi @sfirke! The X-Axis Sort By functionality has been implemented and is functional. The implementation includes: 1. Updated `xAxisSortControl` in `customControls.tsx` to handle dimension-based sorting 2. Modified bar chart control panel to support the new sorting options 3. Added comprehensive unit tests for the new functionality The CI failures are related to pre-existing build issues in the repository (missing `@react-icons/all-files` dependencies) that also occur on the master branch - these are not caused by this PR. All pre-commit checks pass locally. Please let me know if there are specific aspects of the implementation you'd like me to adjust! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
