aminghadersohi commented on PR #37973: URL: https://github.com/apache/superset/pull/37973#issuecomment-3900609538
Addressed all review feedback in d65327189a: **Fixed:** - **Clipboard error handling** (CodeAnt): `handleCopyKey` is now `async` with `try/catch` — shows a danger toast on clipboard failure instead of silently showing "Copied!" on an unhandled promise rejection. - **`has_request_context()` guard** (CodeAnt): API key extraction now only runs when there's an actual HTTP request context, preventing `RuntimeError` in MCP internal operations (tool discovery, etc.) that run with only an application context. - **`handleClose` ordering** (Bito): Moved `onSuccess()` call before state clearing. While React closures mean the original code wasn't technically buggy (`createdKey` retains its value in the closure), the new ordering is clearer about intent. - **antd Tag components** (Bito): Replaced custom styled `<span>` elements with antd `<Tag color="error|warning|success">` components for status badges, following Superset's convention of preferring antd components over custom CSS. **Acknowledged (no change needed):** - **Supply chain risk** (Bito): The git URL dependency on FAB is temporary during development. Will revert to a standard PyPI version pin once [FAB PR #2431](https://github.com/dpgaspar/Flask-AppBuilder/pull/2431) is merged and released. - **Truncate key prefix** (Bito): The `key_prefix` column is already limited to 16 chars in the database schema, so no truncation is needed in the UI. - **Specify locale** (Bito): Using `undefined` locale in `toLocaleDateString()` is intentional — it uses the user's browser locale, which is the correct behavior for an internationalized application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
