bito-code-review[bot] commented on PR #37982:
URL: https://github.com/apache/superset/pull/37982#issuecomment-3903321997

   <!-- Bito Reply -->
   Adding an assertion to ensure decryption fails with the wrong key would 
strengthen the test by confirming the error is due to key mismatch, not just 
producing incorrect output. This makes the test more robust.
   
   **tests/integration_tests/utils/encrypt_tests.py**
   ```
   # Step 6: Verify KEY_A can no longer decrypt the new ciphertext
           self.app.config["SECRET_KEY"] = key_a
           with pytest.raises(ValueError):
               field.process_result_value(encrypted_b, dialect)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to