EnxDev opened a new pull request, #38014: URL: https://github.com/apache/superset/pull/38014
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When a chart query fails and an error banner is displayed inside the chart panel; whether on a dashboard or in the explore view — users could dismiss it via a close button. This was misleading because the error condition hasn't actually been resolved; the chart is still broken, and removing the banner just hides that fact. The user would then see an empty chart tile with no indication of what went wrong. This change threads a `closable` prop through the error message component chain so that `ChartErrorMessage` can explicitly opt out of the close button. The default behavior for all other error surfaces (SQL Lab, standalone alerts, etc.) remains unchanged — they still render a dismissible close button as before. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> - Before <img width="469" height="447" alt="x-after" src="https://github.com/user-attachments/assets/0c52313e-0fb8-4169-897b-281ab847ad8f"; /> - After <img width="469" height="447" alt="Screenshot 2026-02-12 151813" src="https://github.com/user-attachments/assets/cb72c5ab-cec5-4837-b280-b3ca441dd5fa"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Open a dashboard that contains a chart with a known query error (or deliberately break a chart's query to trigger a failure) 2. Observe the error banner displayed inside the chart tile; verify there is no close/X button on the error alert 3. Open the explore view for the same broken chart; verify the error banner there also has no close button 4. Navigate to SQL Lab, run an invalid query that triggers an error; verify the error alert there still has a close button (this behavior should be unchanged) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
