bito-code-review[bot] commented on PR #37970: URL: https://github.com/apache/superset/pull/37970#issuecomment-3914322011
<!-- Bito Reply --> Yes, extracting shared constants like GRID_DEFAULT_CHART_WIDTH and GRID_COLUMN_COUNT to a dedicated constants file is a good practice to reduce duplication and improve maintainability. **superset/mcp_service/dashboard/constants.py** ``` # Shared dashboard constants GRID_DEFAULT_CHART_WIDTH = 4 GRID_COLUMN_COUNT = 12 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
