joe-clickhouse commented on code in PR #34091:
URL: https://github.com/apache/superset/pull/34091#discussion_r2818665874
##########
tests/unit_tests/db_engine_specs/test_clickhouse.py:
##########
@@ -229,6 +229,33 @@ def test_connect_make_label_compatible(column_name: str,
expected_result: str) -
assert label == expected_result
[email protected](
+ "extra,column_name,expected_result",
+ [
+ # Default behavior (mutate labels)
+ (None, "time", "time_07cc69"),
+ ({}, "time", "time_07cc69"),
+ # Explicitly enable
+ ({"mutate_label_name": True}, "time", "time_07cc69"),
Review Comment:
Good catch. Label mutation hash default switched from md5 to sha256. Will
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
