martyngigg commented on code in PR #38069:
URL: https://github.com/apache/superset/pull/38069#discussion_r2822746653
##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -131,7 +132,13 @@ export default function Login() {
sessionStorage.setItem('login_attempted', 'true');
// Use standard form submission for Flask-AppBuilder compatibility
- SupersetClient.postForm(loginEndpoint, values, '');
+ SupersetClient.postForm({
+ endpoint: loginEndpoint,
+ payload: values,
+ target: '',
+ }).finally(() => {
+ setLoading(false);
Review Comment:
This does not look right, SupersetClientClass.postForm is marked async
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
