rusackas commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r2824940205
##########
superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx:
##########
@@ -187,6 +201,46 @@ export const useHeaderActionsMenu = ({
const menuItems: MenuItem[] = [];
+ // Mobile-only: show dashboard info items in menu
+ if (isMobile && !editMode) {
+ // Favorite toggle
+ if (saveFaveStar) {
+ menuItems.push({
+ key: 'toggle-favorite',
+ label: isStarred ? t('Remove from favorites') : t('Add to
favorites'),
+ });
+ }
+
+ // Published status
+ menuItems.push({
+ key: 'status-info',
+ label: isPublished ? t('Status: Published') : t('Status: Draft'),
+ disabled: true,
+ });
+
+ // Owner info
+ const ownerNames =
+ dashboardInfo?.owners?.length > 0
+ ? dashboardInfo.owners.map(getOwnerName).join(', ')
+ : t('None');
+ menuItems.push({
+ key: 'owner-info',
+ label: `${t('Owner')}: ${ownerNames}`,
+ disabled: true,
+ });
+
+ // Last modified
+ const modifiedBy =
+ getOwnerName(dashboardInfo?.changed_by) || t('Not available');
+ menuItems.push({
+ key: 'modified-info',
+ label: `${t('Modified')} ${dashboardInfo?.changed_on_delta_humanized
|| ''} ${t('by')} ${modifiedBy}`,
Review Comment:
✅ Fixed in commit 353681a. Changed both labels to use proper interpolation:
- Owner: `t('Owner: %(names)s', { names: ownerNames })`
- Modified: `t('Modified %(date)s by %(user)s', { date, user })`
This allows translators to reorder placeholders as needed for different
language structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
