hainenber commented on code in PR #37923:
URL: https://github.com/apache/superset/pull/37923#discussion_r2825537920
##########
superset-frontend/packages/superset-ui-core/src/utils/dates.ts:
##########
@@ -40,8 +40,33 @@ dayjs.updateLocale('en', {
invalidDate: 'Invalid date',
});
-export const extendedDayjs = dayjs;
-export type { Dayjs };
+// Extended Dayjs instance type with plugin methods
+export interface ExtendedDayjs extends Dayjs {
+ utc(keepLocalTime?: boolean): ExtendedDayjs;
Review Comment:
we should add comments to help future people understanding what `dayjs`
plugin that these methods got defined, so that when they extend with new
plugin, they can expand this interface further.
```suggestion
// Derived from dayjs/plugin/utc.
utc(keepLocalTime?: boolean): ExtendedDayjs;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
