kgabryje opened a new pull request, #38105: URL: https://github.com/apache/superset/pull/38105
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Previously, the default Metrics and Columns folders were stripped before saving and recreated on load, which meant their position relative to custom folders was lost. This change persists default folders so their ordering is preserved across saves. Unassigned metrics/columns (e.g., newly added after last save) are now appended to existing default folders rather than creating duplicate fallback folders. Also includes a fix for calculated columns, which were not appearing in folders editor ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1. Enable `DATASET_FOLDERS` ff 2. Open the dataset editor with folders enabled 3. Create a custom folder and drag it between the default Metrics and Columns folders 4. Save the dataset 5. Verify that the order is persisted in the datasource panel in Explore 6. Verify that the order is persisted in the folders editor 7. Add a new metric or column to the dataset, reopen folders, and verify it appears in the appropriate default folder ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
