rusackas commented on code in PR #38106:
URL: https://github.com/apache/superset/pull/38106#discussion_r2830142680
##########
superset-frontend/webpack.config.js:
##########
@@ -317,7 +317,10 @@ const config = {
menu: addPreamble('src/views/menu.tsx'),
spa: addPreamble('src/views/index.tsx'),
embedded: addPreamble('src/embedded/index.tsx'),
- 'service-worker': path.join(APP_DIR, 'src/service-worker.ts'),
+ // Skip service-worker build in dev mode to avoid overwriting the
placeholder
+ ...(isDevMode ? {} : {
+ 'service-worker': path.join(APP_DIR, 'src/service-worker.ts'),
+ }),
Review Comment:
```suggestion
})
```
I suspect this is the pre-commit problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
