rusackas commented on code in PR #36951: URL: https://github.com/apache/superset/pull/36951#discussion_r2830288076
########## superset/config.py: ########## @@ -355,20 +355,30 @@ def _try_json_readsha(filepath: str, length: int) -> str | None: APP_NAME = "Superset" # Specify the App icon +# NOTE: This variable is used to populate THEME_DEFAULT. If you override this in +# superset_config.py, you must also override THEME_DEFAULT to see the change, +# or set THEME_DEFAULT["token"]["brandLogoUrl"] directly. APP_ICON = "/static/assets/images/superset-logo-horiz.png" # Specify where clicking the logo would take the user' # Default value of None will take you to '/superset/welcome' # You can also specify a relative URL e.g. '/superset/welcome' or '/dashboards/list' # or you can specify a full URL e.g. 'https://foo.bar' +# NOTE: This variable is used to populate THEME_DEFAULT. If you override this in +# superset_config.py, you must also override THEME_DEFAULT to see the change, +# or set THEME_DEFAULT["token"]["brandLogoHref"] directly. LOGO_TARGET_PATH = None # Specify tooltip that should appear when hovering over the App Icon/Logo +# NOTE: This variable is deprecated and not used in the new theme system. LOGO_TOOLTIP = "" # Specify any text that should appear to the right of the logo +# NOTE: This variable is deprecated and not used in the new theme system. LOGO_RIGHT_TEXT: Callable[[], str] | str = "" +# APP_ICON_WIDTH is deprecated. Use THEME_DEFAULT["token"]["brandLogoHeight"] instead (default: "24px"). Review Comment: ```suggestion # APP_ICON_WIDTH is deprecated. # Use THEME_DEFAULT["token"]["brandLogoHeight"] instead (default: "24px"). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
