kgabryje opened a new pull request, #38123: URL: https://github.com/apache/superset/pull/38123
### SUMMARY The DatasourceModal's CSS selectors targeted Bootstrap-era class names (.modal-content, .modal-body, etc.) instead of antd v5's .ant-modal-* classes, so the intended 900px height and flex layout were never applied. This left the modal body without a definite height, forcing FoldersEditor to use a hardcoded 70vh that caused an unnecessary scrollbar. Fix the selectors and establish a complete flex chain from the modal body through DatasourceContainer and Tabs down to FoldersContainer, which can now use height: 100% instead of the viewport-relative workaround. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1. Open dataset modal 2. Verify that the modal has a fixed height 3. Verify that there's no unnecessary scrollbar in Folders tab ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
