gabotorresruiz commented on code in PR #38017:
URL: https://github.com/apache/superset/pull/38017#discussion_r2834269873
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/formatters.ts:
##########
@@ -29,13 +29,82 @@ import {
SMART_DATE_ID,
SMART_DATE_VERBOSE_ID,
TimeFormatter,
+ TimeGranularity,
ValueFormatter,
} from '@superset-ui/core';
export const getSmartDateDetailedFormatter = () =>
getTimeFormatter(SMART_DATE_DETAILED_ID);
-export const getSmartDateFormatter = () => getTimeFormatter(SMART_DATE_ID);
+export const getSmartDateFormatter = (timeGrain?: string) => {
+ const baseFormatter = getTimeFormatter(SMART_DATE_ID);
+
+ // If no time grain provided, use the standard smart date formatter
+ if (!timeGrain) {
+ return baseFormatter;
+ }
+
+ // Create a wrapper that normalizes dates based on time grain
+ return new TimeFormatter({
+ id: SMART_DATE_ID,
+ label: baseFormatter.label,
+ formatFunc: (date: Date) => {
+ // Create a normalized date based on time grain to ensure consistent
smart formatting
+ const normalizedDate = new Date(date);
+
+ // Always remove milliseconds to prevent .XXXms format
+ normalizedDate.setMilliseconds(0);
+
+ // For all time grains, normalize using UTC methods to avoid timezone
issues
+ if (timeGrain === TimeGranularity.YEAR) {
Review Comment:
So quick question here. I see that the `TimeGranularity` has more
pre-defined values like `WEEK_STARTING_SUNDAY`, `WEEK_STARTING_MONDAY`,
`WEEK_ENDING_SATURDAY`, `WEEK_ENDING_SUNDAY`.
So I'm not sure if we should handle all these variations here to avoid
displaying raw timestamps with milliseconds
##########
superset/static/service-worker.js:
##########
Review Comment:
Do we need this file to be pushed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
