YousufFFFF opened a new pull request, #38126: URL: https://github.com/apache/superset/pull/38126
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR fixes incorrect time shift behavior in the ECharts Timeseries path used by the Bar chart. Fixes #36966. Previously, when a time shift (e.g., 1 month, 5 months) was applied, the shifted series was not properly aligned during series construction inside `transformProps.ts`. This caused incorrect rendering and misalignment of shifted data along the x-axis. This update corrects the time shift handling logic to ensure proper timestamp alignment and consistent rendering across different shift values and dimension combinations. --- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before (Time Shift Not Functioning Correctly)** - Time shift not reflected properly on x-axis **After (Time Shift Working as Expected)** https://github.com/user-attachments/assets/725228bd-910f-4924-a1f2-ea3d0aca99f4 - Shifted series aligns correctly with timestamps - Multiple shift values render properly - Behavior consistent with expected time shift semantics --- ### TESTING INSTRUCTIONS 1. Create a **Bar Chart** 2. Select **Timeseries** mode 3. Add a metric 4. Apply a **Time Shift** (e.g., `1 month`, `5 months`) 5. Optionally add one or more **Dimensions** 6. Verify: - Shifted series renders correctly - X-axis alignment is accurate - No duplicated or broken series - Chart behaves consistently across different shift values Tested locally using Docker environment. --- ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #36966 - [ ] Required feature flags - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in SIP-59) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
