rusackas commented on PR #38117:
URL: https://github.com/apache/superset/pull/38117#issuecomment-3937153811
Saw the Copilot comments, and asked Claude about them, since they sounded a
bit scary on paper:
**Verdict**: Not major concerns
- The PR correctly fixes the main bug (the 404 error from the theme object)
- The Copilot suggestions are nice-to-have improvements for cleanliness but
not critical
- The PR has already been approved by a maintainer (@justinpark)
- No functional breakage would result from the current implementation
The suggestions would make the code more defensive by excluding all
unnecessary props, but the current fix is sufficient to resolve the actual
bug. If you wanted to be thorough, you could address them in a follow-up,
but
they're not blocking issues.
Thoughts on that, @copilot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
