rusackas opened a new pull request, #38162: URL: https://github.com/apache/superset/pull/38162
## Summary Fixes #28060 - "Default filters values cause filter fields to disappear in dashboards" This PR fixes an issue where the "More filters" button would disappear when filter values were set to their defaults and nothing was overflowing the filter bar container. ### Changes - Added `shouldShowButton` flag in `DropdownContainer` that ensures the button is always visible when items exist - The button now remains stable regardless of overflow state, preventing layout shifts - The badge correctly shows 0 when nothing is overflowing - Updated tests to reflect the new expected behavior ### Root Cause The button rendering was conditioned on `popoverContent` being truthy, which required either: 1. `dropdownContent` prop to be defined, OR 2. `overflowingCount > 0` When neither condition was met (common when all filters fit in the container with default values), the button would completely disappear. ### Before/After | Before | After | |--------|-------| | Button disappears when no overflow | Button always visible with badge showing "0" | | Layout shifts when resizing window | Consistent, stable UI | ## Test plan 1. Create a dashboard with multiple filters 2. Set all filters to their default values 3. Make the filter bar wide enough that nothing overflows 4. ✅ Verify the "More filters" button remains visible with a "0" badge 5. ✅ Resize the window to trigger overflow - button should update count accordingly 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
