bito-code-review[bot] commented on code in PR #38094:
URL: https://github.com/apache/superset/pull/38094#discussion_r2840970194
##########
superset-frontend/src/visualizations/TimeTable/TimeTable.tsx:
##########
@@ -81,6 +81,12 @@ const TimeTable = ({
const valueField = row.label || row.metric_name || '';
const cellValues = columnConfigs.reduce<Record<string, ReactNode>>(
(acc, columnConfig) => {
+ const { value } = calculateCellValue(
+ valueField,
+ columnConfig,
+ reversedEntries,
+ );
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unnecessary Computation Duplication</b></div>
<div id="fix">
calculateCellValue is called here for cellValues, but ValueCell already
calls it internally. This creates unnecessary duplication and performance
overhead. Sparkline doesn't use the value but it's still calculated.
</div>
</div>
<small><i>Code Review Run #6b7914</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx:
##########
@@ -208,7 +208,7 @@ const SparklineCell = ({
return null;
}
- const value = data[idx] ?? 0;
+ const value = data[idx];
const timeValue = entries[idx]?.time;
return (
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Tooltip shows 'null' for missing data</b></div>
<div id="fix">
Removing the nullish coalescing (?? 0) causes null values in data to be
passed to formatNumber, which returns the string 'null' in the tooltip. This
provides poor user experience compared to hiding the tooltip or defaulting to
0. Consider adding 'if (value == null) return null;' to skip the tooltip for
null data points.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
const value = data[idx];
if (value == null) return null;
const timeValue = entries[idx]?.time;
return (
````
</div>
</details>
</div>
<small><i>Code Review Run #6b7914</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
