kgabryje commented on code in PR #37459:
URL: https://github.com/apache/superset/pull/37459#discussion_r2841120804


##########
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx:
##########
@@ -132,6 +132,7 @@ function Echart(
     selectedValues = {},
     refs,
     vizType,

Review Comment:
   Could we just get isRefreshing value from Redux instead of propagating it 
through props? That would reduce the boilerplate a lot if we didn't need to 
adjust ~20 charts for that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to