rusackas opened a new pull request, #38193:
URL: https://github.com/apache/superset/pull/38193
### SUMMARY
When the dashboard filter bar recalculates its layout (e.g., on resize or
filter changes), the dropdown "More" button can momentarily disappear and
reappear. This happens because the `DropdownContainer` hides the button when
`popoverContent` is empty — which occurs briefly during re-renders before
overflow detection runs.
This PR adds an `alwaysShowDropdownButton` prop to `DropdownContainer` that
keeps the button visible even when no items are currently overflowing. The
`FilterControls` component passes this prop when there are filter items,
preventing the flickering behavior.
**Changes:**
- Added `alwaysShowDropdownButton` prop to `DropdownContainerProps` type
- Updated `DropdownContainer` render logic to show the button when the new
prop is set
- Passed `alwaysShowDropdownButton={items.length > 0}` in `FilterControls`
- Added unit tests for the new prop
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:** The dropdown button briefly disappears during layout
recalculations, causing a jarring flicker.
**After:** The dropdown button remains stable and visible at all times when
filters are present.
### TESTING INSTRUCTIONS
1. Open a dashboard with enough native filters that some overflow into the
"More" dropdown
2. Resize the browser window or toggle filter visibility
3. Observe that the dropdown button no longer flickers/disappears during
layout recalculations
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
