andy-clapson commented on PR #37614: URL: https://github.com/apache/superset/pull/37614#issuecomment-3946660689
> LGTM, with one minor nit (non-blocking) > > The PREVIEW_QUERY_LIMIT = 100 constant is defined inline inside the if block. It could arguably live as a module-level constant or come from config, but for a preview query hard-coded at 100 this is perfectly fine. easy, and yep good point. Made that change and force pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
