YuriyKrasilnikov commented on PR #37516: URL: https://github.com/apache/superset/pull/37516#issuecomment-3947025739
Thanks for the review @rusackas. `CHART_DATA_INCLUDE_TIMING` is a great idea — all three points addressed in `8725a7e`: **1. Security — timing always exposed** Added `CHART_DATA_INCLUDE_TIMING` config option (default `False`). Timing data is still collected internally for `STATS_LOGGER` and slow-query logging, but omitted from the API response unless explicitly enabled. **2. `db_execution_ms` inconsistency** Fixed. On cache hit, `db_execution_ms` is now explicitly set to `None` instead of being absent from the dict. This matches both the Marshmallow schema (`allow_none=True`) and the TypeScript type (`number | null`). **3. `stats_logger` units** Fixed. Removed the `/1000` division — values are now sent as milliseconds, consistent with `BaseStatsLogger.timing()` convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
