bito-code-review[bot] commented on code in PR #38213:
URL: https://github.com/apache/superset/pull/38213#discussion_r2845485843
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -1136,7 +1138,9 @@ export class TableRenderer extends Component<
true,
)}
>
- {t('Subtotal')}
+ {t('Subvalue (%(aggregatorName)s)', {
+ aggregatorName: t(this.props.aggregatorName),
+ })}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect translation key for row subtotal
labels</b></div>
<div id="fix">
Similar to the column subtotal above, this row subtotal label uses 'Subvalue
(%(aggregatorName)s)' which should be 'Subtotal (%(aggregatorName)s)' for
correct terminology and consistency with totals.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
{t('Subtotal (%(aggregatorName)s)', {
aggregatorName: t(this.props.aggregatorName),
})}
````
</div>
</details>
</div>
<small><i>Code Review Run #25624c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -1136,7 +1138,9 @@ export class TableRenderer extends Component<
true,
)}
>
- {t('Subtotal')}
+ {t('Subvalue (%(aggregatorName)s)', {
+ aggregatorName: t(this.props.aggregatorName),
+ })}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect translation key for subtotal labels</b></div>
<div id="fix">
The translation key 'Subvalue (%(aggregatorName)s)' appears incorrect;
'Subvalue' is not a recognized term in pivot tables or data aggregation. Based
on standard terminology and the pattern used for totals ('Total
(%(aggregatorName)s)'), this should be 'Subtotal (%(aggregatorName)s)' to
display labels like 'Subtotal (Sum)'.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
{t('Subtotal (%(aggregatorName)s)', {
aggregatorName: t(this.props.aggregatorName),
})}
````
</div>
</details>
</div>
<small><i>Code Review Run #25624c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
