richardfogaca commented on PR #37459: URL: https://github.com/apache/superset/pull/37459#issuecomment-3951432503
You're right @kgabryje thanks for catching that. Here's what I updated on the lastest changes: 1. I removed the leftover isRefreshing passthrough from the ECharts transformProps.ts files, and kept only the Tree chart specific usage since that one is still needed to disable tree animation during refresh. 2. Fixed the periodic refresh path to go through onRefresh(..., skipFiltersRefresh=true) instead of calling fetchCharts directly, so ON_REFRESH/ON_REFRESH_SUCCESS are dispatched consistently and dashboardState.isRefreshing stays in sync for ECharts refresh handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
