msyavuz commented on code in PR #38030:
URL: https://github.com/apache/superset/pull/38030#discussion_r2851912686
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.ts:
##########
@@ -298,7 +301,8 @@ function WorldMap(element: HTMLElement, props:
WorldMapProps): void {
.selectAll('.datamaps-subunit')
.on('contextmenu', handleContextMenu)
.on('click', handleClick)
- .on('mouseover', function onMouseOver() {
+ // Use namespaced events to avoid overriding Datamaps' default tooltip
handlers
+ .on('mouseover.fillPreserve', function onMouseOver() {
Review Comment:
Pretty cool we can do namespaced events with d3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
