bito-code-review[bot] commented on code in PR #38253:
URL: https://github.com/apache/superset/pull/38253#discussion_r2854620791
##########
docs/yarn.lock:
##########
@@ -2679,6 +2716,58 @@
dependencies:
langium "3.3.1"
+"@module-federation/[email protected]":
+ version "0.22.0"
+ resolved
"https://registry.yarnpkg.com/@module-federation/error-codes/-/error-codes-0.22.0.tgz#31ccc990dc240d73912ba7bd001f7e35ac751992";
+ integrity
sha512-xF9SjnEy7vTdx+xekjPCV5cIHOGCkdn3pIxo9vU7gEZMIw0SvAEdsy6Uh17xaCpm8V0FWvR0SZoK9Ik6jGOaug==
+
+"@module-federation/[email protected]":
+ version "0.22.0"
+ resolved
"https://registry.yarnpkg.com/@module-federation/runtime-core/-/runtime-core-0.22.0.tgz#7321ec792bb7d1d22bee6162ec43564b769d2a3c";
+ integrity
sha512-GR1TcD6/s7zqItfhC87zAp30PqzvceoeDGYTgF3Vx2TXvsfDrhP6Qw9T4vudDQL3uJRne6t7CzdT29YyVxlgIA==
+ dependencies:
+ "@module-federation/error-codes" "0.22.0"
+ "@module-federation/sdk" "0.22.0"
+
+"@module-federation/[email protected]":
+ version "0.22.0"
+ resolved
"https://registry.yarnpkg.com/@module-federation/runtime-tools/-/runtime-tools-0.22.0.tgz#36f2a7cb267af208a9d1a237fe9a71b4bf31431e";
+ integrity
sha512-4ScUJ/aUfEernb+4PbLdhM/c60VHl698Gn1gY21m9vyC1Ucn69fPCA1y2EwcCB7IItseRMoNhdcWQnzt/OPCNA==
+ dependencies:
+ "@module-federation/runtime" "0.22.0"
+ "@module-federation/webpack-bundler-runtime" "0.22.0"
+
+"@module-federation/[email protected]":
+ version "0.22.0"
+ resolved
"https://registry.yarnpkg.com/@module-federation/runtime/-/runtime-0.22.0.tgz#f789c9ef40d846d110711c8221ecc0ad938d43d8";
+ integrity
sha512-38g5iPju2tPC3KHMPxRKmy4k4onNp6ypFPS1eKGsNLUkXgHsPMBFqAjDw96iEcjri91BrahG4XcdyKi97xZzlA==
+ dependencies:
+ "@module-federation/error-codes" "0.22.0"
+ "@module-federation/runtime-core" "0.22.0"
+ "@module-federation/sdk" "0.22.0"
+
+"@module-federation/[email protected]":
+ version "0.22.0"
+ resolved
"https://registry.yarnpkg.com/@module-federation/sdk/-/sdk-0.22.0.tgz#6ad4c1de85a900c3c80ff26cb87cce253e3a2770";
+ integrity
sha512-x4aFNBKn2KVQRuNVC5A7SnrSCSqyfIWmm1DvubjbO9iKFe7ith5niw8dqSFBekYBg2Fwy+eMg4sEFNVvCAdo6g==
+
+"@module-federation/[email protected]":
+ version "0.22.0"
+ resolved
"https://registry.yarnpkg.com/@module-federation/webpack-bundler-runtime/-/webpack-bundler-runtime-0.22.0.tgz#dcbe8f972d722fe278e6a7c21988d4bee53d401d";
+ integrity
sha512-aM8gCqXu+/4wBmJtVeMeeMN5guw3chf+2i6HajKtQv7SJfxV/f4IyNQJUeUQu9HfiAZHjqtMV5Lvq/Lvh8LdyA==
+ dependencies:
+ "@module-federation/runtime" "0.22.0"
+ "@module-federation/sdk" "0.22.0"
+
+"@napi-rs/[email protected]":
+ version "1.0.7"
+ resolved
"https://registry.yarnpkg.com/@napi-rs/wasm-runtime/-/wasm-runtime-1.0.7.tgz#dcfea99a75f06209a235f3d941e3460a51e9b14c";
+ integrity
sha512-SeDnOO0Tk7Okiq6DbXmmBODgOAb9dp9gjlphokTUxmt8U3liIP1ZsozBahH69j/RJv+Rfs6IwUKHTgQYJ/HBAw==
+ dependencies:
+ "@emnapi/core" "^1.5.0"
+ "@emnapi/runtime" "^1.5.0"
+ "@tybys/wasm-util" "^0.10.1"
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dependency Lockfile Inconsistency</b></div>
<div id="fix">
The yarn.lock file has been modified to include new dependencies
(@module-federation/* and @napi-rs/wasm-runtime), but these are not present in
docs/package.json. This creates an inconsistency, as yarn.lock should be
auto-generated from package.json. Manually editing yarn.lock can lead to
unreliable dependency resolution, where running 'yarn install' might remove or
alter these entries.
</div>
</div>
<small><i>Code Review Run #67974c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
