EnxDev commented on code in PR #38276:
URL: https://github.com/apache/superset/pull/38276#discussion_r2864913933
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx:
##########
@@ -92,7 +92,10 @@ export function mapColumns<T extends object>(
const { isSorted, isSortedDesc } = getSortingInfo(headerGroups, column.id);
return {
title: column.Header,
- dataIndex: column.id?.includes('.') ? column.id.split('.') : column.id,
+ dataIndex:
+ typeof column.id === 'string' && column.id.includes('.')
+ ? column.id.split('.')
+ : column.id,
Review Comment:
It is already defined as string, probably this check is redundant, I'll
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
