codeant-ai-for-open-source[bot] commented on PR #38316:
URL: https://github.com/apache/superset/pull/38316#issuecomment-3982177402
## **Sequence Diagram**
The PR updates ensureAppRoot to pass through absolute (scheme:) and
protocol-relative (//...) URLs unchanged, while continuing to prefix relative
paths with the application root. makeUrl delegates to ensureAppRoot and Menu
uses the resolved value for the brand logo link href.
```mermaid
sequenceDiagram
participant Menu (UI)
participant pathUtils
participant getBootstrapData
participant Browser
Menu->>pathUtils: makeUrl(brandLogoHref)
pathUtils->>pathUtils: if input matches RFC3986 scheme or
startsWith("//")
alt Absolute or protocol-relative
pathUtils-->>Menu: return original URL (unchanged)
else Relative path
pathUtils->>getBootstrapData: applicationRoot()
getBootstrapData-->>pathUtils: "/superset" (example)
pathUtils-->>Menu: return "/superset/..." (prefixed)
end
Menu->>Browser: render <a href="resolved URL"> (brand link)
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
