Aitema-gmbh commented on PR #38342: URL: https://github.com/apache/superset/pull/38342#issuecomment-3984397591
Hi @geido @kgabryje @michael-s-molina @rusackas 👋 This is a clean rewrite of #37211, rebased on current `master` with all bot review feedback addressed: - ✅ SkipLink `tabindex` bug fixed (temporary on focus, removed on blur) - ✅ Correct import paths (`@apache-superset/core/ui`, `@superset-ui/core/components`) - ✅ No more ActionButtons modifications (upstream logic is already correct) - ✅ Minimal SliceHeader diff — just a semantic `<h2>` wrapper + CSS reset The scope is intentionally focused: 2 new accessibility components (SkipLink, StatusAnnouncer) + 1 small semantic heading change. Unit tests included. Would really appreciate a review when you have time! Happy to address any feedback. 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
