msyavuz commented on code in PR #35021: URL: https://github.com/apache/superset/pull/35021#discussion_r2877195100
########## superset-frontend/src/pages/RedirectWarning/utils.ts: ########## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +const TRUSTED_URLS_KEY = 'superset_trusted_urls'; +const MAX_TRUSTED_URLS = 100; +const ALLOWED_SCHEMES = ['http:', 'https:']; + +/** + * Normalize a URL for comparison (origin + path without trailing slash + search). + */ +function normalizeUrl(url: string): string { + try { + const parsed = new URL(url); + return parsed.origin + parsed.pathname.replace(/\/$/, '') + parsed.search; + } catch { + return url; + } +} + +/** + * Return true if the URL scheme is safe for navigation. + * Blocks javascript:, data:, vbscript:, file:, etc. + */ +export function isAllowedScheme(url: string): boolean { + try { + const parsed = new URL(url); + return ALLOWED_SCHEMES.includes(parsed.protocol); + } catch { + // relative URLs or unparseable — allow (they'll resolve against current origin) + return true; + } +} + +/** + * Read the target URL from the current page's query string. + * + * URLSearchParams.get() already percent-decodes the value, so we must NOT + * call decodeURIComponent again (doing so would allow double-encoded + * payloads like `javascript%253Aalert(1)` to bypass scheme checks). + */ +export function getTargetUrl(): string { + const params = new URLSearchParams(window.location.search); + const url = params.get('url') ?? ''; + return url.trim(); +} + +function getTrustedUrls(): string[] { + try { + const stored = localStorage.getItem(TRUSTED_URLS_KEY); + if (!stored) return []; + const parsed: unknown = JSON.parse(stored); + return Array.isArray(parsed) ? (parsed as string[]) : []; + } catch { + return []; + } +} + +function saveTrustedUrls(urls: string[]): void { + const limited = + urls.length > MAX_TRUSTED_URLS ? urls.slice(-MAX_TRUSTED_URLS) : urls; + try { + localStorage.setItem(TRUSTED_URLS_KEY, JSON.stringify(limited)); + } catch { + // Ignore storage errors (private browsing, quota exceeded, etc.) + } +} + +export function isUrlTrusted(url: string): boolean { + const normalized = normalizeUrl(url); + return getTrustedUrls().some(t => normalizeUrl(t) === normalized); +} + +export function trustUrl(url: string): void { + const normalized = normalizeUrl(url); + const trusted = getTrustedUrls(); + if (!trusted.some(t => normalizeUrl(t) === normalized)) { + trusted.push(url); + saveTrustedUrls(trusted); + } +} Review Comment: Should there be something like `clearTrustedUrls` ? ########## superset-frontend/src/pages/RedirectWarning/index.tsx: ########## Review Comment: Might be a good time to use Ant Design's Result component? We already have it in components directory. https://ant.design/components/result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
