madhushreeag commented on code in PR #37531:
URL: https://github.com/apache/superset/pull/37531#discussion_r2881104446
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:
##########
@@ -63,7 +63,7 @@ describe('Bar Chart X-axis Time Formatting', () => {
});
const transformedProps = transformProps(
- chartProps as EchartsTimeseriesChartProps,
+ chartProps as unknown as EchartsTimeseriesChartProps,
Review Comment:
Removed one double cast but keeping others. These tests construct untyped
formData objects by spreading baseFormData: SqlaFormData, which means
TypeScript's static type only sees SqlaFormData fields. The
EchartsTimeseriesFormData-specific required fields (annotationLayers, area,
forecastEnabled, etc.) are invisible to the type checker even though they exist
at runtime via DEFAULT_FORM_DATA. The unknown intermediate is the correct and
legitimate escape hatch for this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
