aminghadersohi commented on code in PR #38373:
URL: https://github.com/apache/superset/pull/38373#discussion_r2882538334
##########
superset/mcp_service/dashboard/tool/generate_dashboard.py:
##########
@@ -177,10 +211,15 @@ def generate_dashboard(
with event_logger.log_context(action="mcp.generate_dashboard.layout"):
layout = _create_dashboard_layout(chart_objects)
+ # Resolve dashboard title: use provided title or derive from chart
names
+ dashboard_title = request.dashboard_title or
_generate_title_from_charts(
+ chart_objects
+ )
+
# Prepare dashboard data and create dashboard
with
event_logger.log_context(action="mcp.generate_dashboard.db_write"):
Review Comment:
Good catch — switched to an explicit `is not None` check so an empty string
is preserved as-is. Added a test for the edge case too. See d85ac74.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
