aminghadersohi opened a new pull request, #38389: URL: https://github.com/apache/superset/pull/38389
### SUMMARY Several ECharts-based chart types (Timeseries, MixedTimeseries, BoxPlot, etc.) default `yAxisTitleMargin` to `0`. This value feeds directly into ECharts' `nameGap` configuration, which controls the spacing between the y-axis title and its tick labels. With `nameGap: 0`, whenever a user adds a y-axis title the text renders on top of the tick labels, making both unreadable. This PR changes the default `yAxisTitleMargin` from `0` to `15` in: - `DEFAULT_TITLE_FORM_DATA` (shared across multiple chart types) - `DEFAULT_FORM_DATA` in the Timeseries constants (which inlines the same defaults) A value of 15 provides enough spacing to prevent overlap without being excessive. For reference, the Histogram chart already hardcodes `nameGap: 40`/`55`, and the Bubble chart defaults to `yAxisTitleMargin: 30`. Test fixtures that hardcoded the old default of `0` as form data input have been updated to match. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before**: Y-axis title text overlaps with tick labels when `yAxisTitleMargin` defaults to 0. **After**: Y-axis title text has 15px of spacing from tick labels, making both legible. ### TESTING INSTRUCTIONS 1. Open any Timeseries, MixedTimeseries, or BoxPlot chart in Explore 2. In the Customize tab, set a Y-Axis Title (e.g. "Revenue") 3. Verify the title no longer overlaps with the axis tick labels 4. Verify that manually adjusting the Y-Axis Title Margin control still works as expected ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
