michael-s-molina opened a new pull request, #38394:
URL: https://github.com/apache/superset/pull/38394
### SUMMARY
Relocates the `superset_core.mcp` package from a standalone top-level module
(`superset_core/mcp/__init__.py`) into the existing `api` package as
`superset_core/api/mcp.py`.
This consolidates MCP-related public API surface under `superset_core.api`,
consistent with where other public API abstractions live. The `mcp/__init__.py`
package is removed and replaced by a single module file at
`superset_core/api/mcp.py`.
**Files changed:**
- `superset-core/src/superset_core/api/mcp.py` — new location for `tool` and
`prompt` decorators
- `superset-core/src/superset_core/mcp/` — removed
- `superset/core/mcp/core_mcp_injection.py` — updated dependency injection
to target `superset_core.api.mcp`
- `superset/mcp_service/**` (21 files) — updated all `from superset_core.mcp
import` statements
- `superset/mcp_service/CLAUDE.md` — updated all code examples
- `docs/developer_docs/extensions/mcp.md` — updated all import examples
### TESTING INSTRUCTIONS
1. Verify imports resolve correctly:
```python
from superset_core.api.mcp import tool, prompt
```
2. Start the MCP service and confirm tool/prompt registration works:
```bash
python -m superset.mcp_service.app
```
3. Run the MCP service unit tests:
```bash
pytest tests/unit_tests/mcp_service/
```
4. Confirm the old import path no longer exists:
```bash
grep -r "superset_core\.mcp" . --include="*.py" --include="*.md"
# Should return no results
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
