michael-s-molina opened a new pull request, #38448: URL: https://github.com/apache/superset/pull/38448
### SUMMARY Reorganizes both the Python (`superset_core`) and TypeScript (`superset-core`) packages from layer-based containers into a feature-based structure. This is a clean break — no backward-compatible shims. #### Motivation This follows the same principles as [SIP-61](https://github.com/apache/superset/issues/13632), which reorganized the main `superset-frontend/src/` from layer-based directories into feature-based ones. We apply the same thinking here to `superset_core` and `superset-core`. Both packages previously grouped code by _layer_ (`api/`, `ui/`) rather than by _feature_. The `api/` layer bundled unrelated concerns: query execution types, async task infrastructure, MCP tool decorators, REST API utilities, and shared models — all in the same directory. The `ui/` layer similarly co-located theme tokens, translation utilities, and UI components. This made it hard to understand what a given subpackage was for, and meant every consumer had to know which single file a symbol came from rather than which _domain_. **Python (`superset_core`)** ``` # Before # After superset_core/ superset_core/ └── api/ ├── common/ ├── models.py │ ├── models.py ├── daos.py │ └── daos.py ├── tasks.py ├── queries/ ├── types.py │ ├── types.py ├── query.py │ ├── models.py ├── mcp.py │ ├── daos.py └── rest_api.py │ └── query.py ├── tasks/ │ ├── types.py │ ├── decorators.py │ ├── models.py │ └── daos.py ├── mcp/ │ └── decorators.py ├── rest_api/ │ └── api.py └── extensions/ ``` **TypeScript (`superset-core/src`)** ``` # Before # After src/ src/ ├── api/ ├── common/ │ ├── core.ts │ └── index.ts │ ├── commands.ts ├── commands/ │ ├── editors.ts │ └── index.ts │ ├── views.ts ├── editors/ │ └── ... │ └── index.ts └── ui/ ├── theme/ ├── theme/ │ └── index.ts ├── translation/ ├── translation/ └── components/ │ └── index.ts ├── components/ │ └── Alert.tsx └── utils/ └── index.ts ``` ### TESTING INSTRUCTIONS 1. Run pre-commit: `pre-commit run` — all hooks should pass. 2. Build packages: `npm run plugins:build` inside `superset-frontend/` — all 23 packages should compile cleanly. 3. Run tests ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
