sadpandajoe opened a new pull request, #38457:
URL: https://github.com/apache/superset/pull/38457

   ### SUMMARY
   
   `Menu.test.tsx` was importing from `@apache-superset/core/ui`, a module path 
that doesn't exist. This caused two CI failures on master:
   - **lint-frontend (tsc)**: `TS2307: Cannot find module 
'@apache-superset/core/ui'`
   - **sharded-jest-tests (4)**: Jest `moduleNameMapper` could not resolve the 
path
   
   The correct module is `@apache-superset/core/theme`, which is where 
`useTheme` and `supersetTheme` are exported — and what `Menu.tsx` itself 
imports from.
   
   Introduced in #38316.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — test-only fix.
   
   ### TESTING INSTRUCTIONS
   
   CI should pass:
   - `tsc --noEmit` no longer errors on `Menu.test.tsx`
   - Jest shard 4 no longer fails on `Menu.test.tsx`
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to