mistercrunch opened a new pull request, #38459:
URL: https://github.com/apache/superset/pull/38459

   ### SUMMARY
   
   Adds a `WEBPACK_ALLOW_ALL_HOSTS` env var that, when set, configures 
webpack-dev-server with `allowedHosts: 'all'`. This enables access from 
external IPs (e.g. remote dev environments like Agor, Codespaces, or any 
cloud-based dev setup) without hardcoding host entries.
   
   - **`superset-frontend/webpack.config.js`**: Checks 
`WEBPACK_ALLOW_ALL_HOSTS` env var; when truthy uses `allowedHosts: 'all'`, 
otherwise keeps the existing restrictive list
   - **`docker-compose-light.yml`**: Passes `WEBPACK_ALLOW_ALL_HOSTS=true` by 
default since the light compose already binds to `0.0.0.0`
   - **`.agor.yml`**: Environment template for multi-worktree development using 
`docker-compose-light.yml`
   
   Default local development behavior is unchanged — the env var must be 
explicitly set to opt in.
   
   ### TESTING INSTRUCTIONS
   
   1. Start with `docker-compose-light.yml`: `NODE_PORT=9001 docker compose -f 
docker-compose-light.yml up -d`
   2. Access the dev server from an external IP — should work (previously 
rejected by `allowedHosts`)
   3. Without the env var (`WEBPACK_ALLOW_ALL_HOSTS=`), external access should 
be rejected as before
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to