aminghadersohi commented on PR #38409: URL: https://github.com/apache/superset/pull/38409#issuecomment-4010811370
Good point\! I'll add unit tests for emoji tab names and tabs under ROOT_ID in a follow-up. The manual testing covered those cases, but having them in the test suite would be the right thing to do. Thanks for the review\! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
